Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaned up and improved generalization of mpas_isobaric_diagnostics code #1184

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Commits on Jun 19, 2024

  1. Cleaned up mpas_isobaric_diagnostics.F

     This commit pertains to a series of modifications that clean up
      to currently existing isobaric diagnostics interpolation. The
      existing diagnostics comprise a number of variables at individual
      pressure levels (e.g., temperature_200hPa) and thus require a significant
      amount of hard-coding.
    
      This modified version reduces (but does not eliminate) the need for
      hard-coding by prescribing a list of isobaric levels to which the
      variables are commonly interpolated, leading to variables of the form
      e.g., temperature_isobaric. These variables are also connected to a
      diagnostic package and namelist config option (config_isobaric = .true.)
      to make it easier for users to toggle on their calculation at runtime.
    
      The specific changes include:
    
      - Adding an isobaric package to Registry.xml
    
      - Adding the config_isobaric namelist option to Registry_diagnostics.xml
    
      - Connecting the package variables to the namelist config option in a new script,
        mpas_atm_diagnostics_packages.F, which is called in mpas_atm_core_interface.F
    
      - Updating Registry_isobaric.xml to remove the highly specific variables and
        replace them with more generalizable variables, such as temperature_isobaric
    
      - Updating Registry.xml to change the default diagnostics stream variables
    
      - Updating mpas_isobaric_diagnostics.F with the interpolation of the new
        generalizable variables and removal of the old variables
    
      - Adding halo groups 'isobaric:pressure_p' and 'isobaric:vorticity' to
        mpas_atm_halos.F and removing the previous halo field exchanges from
        mpas_isobaric_diagnostics.F
    
      - Updating mpas_atm_diagnostics_manager.F to include the halo exchange
        and config input arguments to the isobaric subroutine calls
    
      - Updating mpas_atm_core.F to include the halo exchange input arguments
        to mpas_atm_diag_compute()
    theweathermanda committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    b1d8dcd View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e86c7a0 View commit details
    Browse the repository at this point in the history
  3. Update Registry_isobaric.xml

    Added package associations to `mslp` and `meanT_500_300`
    theweathermanda authored Jun 19, 2024
    Configuration menu
    Copy the full SHA
    32234b7 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2024

  1. Update mpas_isobaric_diagnostics.F

    Further cleaned up the script by defining subroutines for each interpolation procedure (cell centers on mass levels, vertices on mass levels, and cell centers on w levels) and for the temperature and dewpoint calculations.
    theweathermanda authored Jun 20, 2024
    Configuration menu
    Copy the full SHA
    6a31aba View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2024

  1. Update mpas_isobaric_diagnostics.F

    Fixed division by 100. for garbage cell. Pressure is already in hPa.
    theweathermanda authored Jun 27, 2024
    Configuration menu
    Copy the full SHA
    39a1c23 View commit details
    Browse the repository at this point in the history