[Feat] #259 - KeyResultService 테스트 코드 작성 #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0lynny
approved these changes
Apr 1, 2024
| public Log createUpdateLog(final KeyResultModifyRequestDto request, final Long keyResultId) { | ||
| KeyResult keyResult = keyResultRepository.findById(keyResultId) | ||
| .orElseThrow(() -> new NotFoundException(NOT_FOUND_KEY_RESULT)); | ||
| public Log createUpdateLog(final KeyResultModifyRequestDto request, final KeyResult keyResult) { |
There was a problem hiding this comment.
p5;
이미 위에서 조회했으니 이렇게 해주었으면 됐었군요 !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀PullRequest🚀
📟 관련 이슈
💻 작업 내용
KeyResultService 테스트 코드 작성을 하였습니다.
기존 ObjectiveService 테스트 코드와 다른 점은 given 절에 BDDMockito를 추가하여 좀 더 직관적인 테스팅 코드를 작성하였습니다.
테스트 코드에서 JPA에 의존하는 메소드 로직은 테스트 검증에서 뺐습니다. 또한 삭제하는 메소드도 JPA에 의존적이라고 판단하여 단위 테스트 코드에서는 뺐습니다. 추후 통합 테스트를 진행할 때 테스트를 진행하도록 하겠습니다!
📝 리뷰 노트
테스트 로직이 KeyResultService를 무결하게 테스트하지 않는다고 생각하시는 경우에 어떤 부분을 보완하면 좋을지 알려주시면 감사하겠습니다~
🧪 테스트 결과