Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/hold fulfillment order #660

Merged
merged 5 commits into from
Aug 20, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -482,12 +482,13 @@ default.
- fulfillmentOrder
- `cancel(id, params)`
- `close(id[, message])`
- `fulfillments(id)`
- `get(id)`
- `hold(id, params)`
- `list([params])`
- `locationsForMove(id)`
- `move(id, locationId)`
- `setFulfillmentOrdersDeadline(params)`
- `fulfillments(id)`
- fulfillmentRequest
- `accept(fulfillmentOrderId[, message])`
- `create(fulfillmentOrderId, params)`
Expand Down
17 changes: 17 additions & 0 deletions resources/fulfillment-order.js
Original file line number Diff line number Diff line change
Expand Up @@ -127,4 +127,21 @@ FulfillmentOrder.prototype.fulfillments = function fulfillments(id) {
return this.shopify.request(url, 'GET', 'fulfillments');
};

/**
* Halts all fulfillment work on a fulfillment order with
* status OPEN and changes the status of the fulfillment order to ON_HOLD.
*
* @param {Number} id Fulfillment Order ID
* @param {Object} params An object containing the reason for the fulfillment
hold and additional optional information
* @return {Promise} Promise that resolves with the result
* @public
*/
FulfillmentOrder.prototype.hold = function hold(id, params) {
const url = this.buildUrl(`${id}/hold`);
return this.shopify
.request(url, 'POST', undefined, { fulfillment_hold: params })
.then((body) => body[this.key]);
};

module.exports = FulfillmentOrder;
7 changes: 7 additions & 0 deletions test/fixtures/fulfillment-order/req/hold.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"fulfillment_hold": {
"reason": "inventory_out_of_stock",
"reason_notes": "Not enough inventory to complete this work.",
"fulfillment_order_line_items": [{ "id": 1058737493, "quantity": 1 }]
}
}
1 change: 1 addition & 0 deletions test/fixtures/fulfillment-order/req/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,6 @@

exports.cancel = require('./cancel');
exports.close = require('./close');
exports.hold = require('./hold');
exports.move = require('./move');
exports.setFulfillmentOrdersDeadline = require('./set-fulfillment-orders-deadline');
61 changes: 61 additions & 0 deletions test/fixtures/fulfillment-order/res/hold.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,61 @@
{
"fulfillment_order": {
"id": 1046000789,
"shop_id": 548380009,
"order_id": 450789469,
"assigned_location_id": 24826418,
"request_status": "unsubmitted",
"status": "on_hold",
"fulfill_at": null,
"supported_actions": ["release_hold"],
"destination": {
"id": 1046000789,
"address1": "Chestnut Street 92",
"address2": "",
"city": "Louisville",
"company": null,
"country": "United States",
"email": "[email protected]",
"first_name": "Bob",
"last_name": "Norman",
"phone": "+1(502)-459-2181",
"province": "Kentucky",
"zip": "40202"
},
"line_items": [
{
"id": 1058737493,
"shop_id": 548380009,
"fulfillment_order_id": 1046000789,
"quantity": 1,
"line_item_id": 518995019,
"inventory_item_id": 49148385,
"fulfillable_quantity": 1,
"variant_id": 49148385
}
],
"international_duties": null,
"fulfillment_holds": [
{
"reason": "inventory_out_of_stock",
"reason_notes": "Not enough inventory to complete this work."
}
],
"fulfill_by": null,
"created_at": "2024-07-24T06:26:32-04:00",
"updated_at": "2024-07-24T06:26:33-04:00",
"delivery_method": null,
"assigned_location": {
"address1": null,
"address2": null,
"city": null,
"country_code": "DE",
"location_id": 24826418,
"name": "Apple Api Shipwire",
"phone": null,
"province": null,
"zip": null
},
"merchant_requests": []
}
}
1 change: 1 addition & 0 deletions test/fixtures/fulfillment-order/res/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,4 @@ exports.close = require('./close');
exports.list = require('./list');
exports.move = require('./move');
exports.get = require('./get');
exports.hold = require('./hold');
15 changes: 15 additions & 0 deletions test/fulfillment-order.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -134,4 +134,19 @@ describe('Shopify#fulfillmentOrder', () => {
.fulfillments(1046000823)
.then((data) => expect(data).to.deep.equal(output.fulfillments));
});

it('applies a fulfillment hold on an open fulfillment order', () => {
const input = fixtures.req.hold;
const output = fixtures.res.hold;

scope
.post('/admin/fulfillment_orders/1046000789/hold.json', input)
.reply(200, output);

return shopify.fulfillmentOrder
.hold(1046000789, input.fulfillment_hold)
.then((data) => {
expect(data).to.deep.equal(output.fulfillment_order);
});
});
});
21 changes: 21 additions & 0 deletions types/index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -389,6 +389,10 @@ declare class Shopify {
fulfillments: (
id: number
) => Promise<Shopify.IPaginatedResult<Shopify.IFulfillment>>;
hold: (
id: number,
params: Shopify.IFulfillmentHold
) => Promise<Shopify.IFulfillmentOrder>;
};
fulfillmentRequest: {
accept: (
Expand Down Expand Up @@ -3567,4 +3571,21 @@ declare namespace Shopify {
};
updated_at: string;
}

interface IFulfillmentHoldFulfillmentOrderLineItem {
id: number;
quantity: number;
}

interface IFulfillmentHold {
reason:
| 'awaiting_payment'
| 'high_risk_of_fraud'
| 'incorrect_address'
| 'inventory_out_of_stock'
| 'other';
reason_notes?: string;
notify_merchant?: boolean;
fulfillment_order_line_items?: IFulfillmentHoldFulfillmentOrderLineItem[];
}
}