Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Kloppy as reader #229

Merged
merged 1 commit into from
Dec 30, 2023
Merged

Add Kloppy as reader #229

merged 1 commit into from
Dec 30, 2023

Conversation

probberechts
Copy link
Member

@probberechts probberechts commented Mar 17, 2022

The goal of this PR is to track progress on #41.

Supported action types

SPADL action Kloppy EventType Tasks
pass PASS ✅ Done
cross PASS + PassQualifier:CROSS ✅ Done
throw_in PASS + SetPieceQualifier:THROW_IN ✅ Done
freekick_crossed PASS + SetPieceQualifier:FREE_KICK + PassQualifier:[CHIPPED_PASS, CROSS, HIGH_PASS, LONG_BALL] ✅ Done
freekick_short PASS + SetPieceQualifier:FREE_KICK ✅ Done
corner_crossed PASS + SetPieceQualifier:CORNER_KICK + PassQualifier:[CHIPPED_PASS, CROSS, HIGH_PASS, LONG_BALL] ✅ Done
corner_short PASS + SetPieceQualifier:CORNER_KICK ✅ Done
take_on TAKE_ON ✅ Done
foul FOUL_COMMITTED ✅ Done
tackle DUEL + DuelType:Ground - DuelType:LOOSE_BALL ✅ Done
interception INTERCEPTION ✅ Done
shot SHOT ✅ Done
shot_penalty SHOT + SetPieceQualifier:PENALTY ✅ Done
shot_freekick SHOT + SetPieceQualifier:FREE_KICK ✅ Done
keeper_save GOAL_KEEPER + GoalKeeperActionType:SAVE - Keeper actions do not have a result in Kloppy. We cannot differentiate between saves that push the ball to a teammate or out of bounds vs allow a dangerous rebound.
keeper_claim GOAL_KEEPER + GoalKeeperActionType:[CLAIM, SMOTHER] ✅ Done
keeper_punch GOAL_KEEPER + GoalKeeperActionType:PUNCH - Keeper actions do not have a result in Kloppy. We cannot differentiate between saves that punch the ball to a teammate or out of bounds vs allow a dangerous rebound.
keeper_pick_up GOAL_KEEPER + GoalKeeperActionType:PICK_UP ✅ Done
clearance CLEARANCE ✅ Done
bad_touch MISCONTROL ✅ Done
non_action / ✅ Done
dribble CARRY ✅ Done
goalkick PASS + SetPieceQualifier:GOAL_KICK ✅ Done

@probberechts probberechts linked an issue Mar 17, 2022 that may be closed by this pull request
@probberechts probberechts added the enhancement New feature or request label Feb 17, 2023
@probberechts probberechts modified the milestone: v2.15 Oct 3, 2023
@probberechts probberechts changed the base branch from master to release/v1.5 October 3, 2023 13:29
@codecov-commenter
Copy link

codecov-commenter commented Oct 3, 2023

Codecov Report

Attention: 30 lines in your changes are missing coverage. Please review.

Comparison is base (571b56d) 83.04% compared to head (c6a8637) 83.19%.

Files Patch % Lines
socceraction/spadl/kloppy.py 85.57% 15 Missing and 15 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@               Coverage Diff                @@
##           release/v1.5     #229      +/-   ##
================================================
+ Coverage         83.04%   83.19%   +0.14%     
================================================
  Files                47       48       +1     
  Lines              3469     3677     +208     
  Branches            574      626      +52     
================================================
+ Hits               2881     3059     +178     
- Misses              493      508      +15     
- Partials             95      110      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@probberechts probberechts marked this pull request as ready for review December 30, 2023 10:28
@probberechts probberechts merged commit abb3039 into release/v1.5 Dec 30, 2023
20 checks passed
@probberechts probberechts deleted the feat-kloppy-reader branch December 30, 2023 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add kloppy as reader
2 participants