Don't crash on encountering an encrypted PDF file #2182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function is a best effort attempt to get text from a PDF file - if the file is malformed (PDFSyntaxError), this function returns an empty string. However, there are other exceptions such as PDFPasswordIncorrect that can occur even if the file is well-formed. Although it would be better to handle these exceptions at a higher level, this is a temporary fix to allow training applications containing encrypted files to be rejected.
|
(i have pushed to the live server) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some people have submitted PDF training reports to PhysioNet that are encrypted with a password. I still don't know why, but at least three people did so.
We can't read them, so presumably these submissions ought to be rejected. However, we currently aren't preventing these submissions, and trying to access the console page to view/reject the submission causes an error (PDFPasswordIncorrect, which is not a subclass of PDFSyntaxError).
This pull should treat encrypted PDF files the same as any other file that the server is unable to parse.
For more long-term solutions see issue #2179.