-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Advances in heat exchanger models #79
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
D_o was already a field in HXgeom small syntax changes
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #79 +/- ##
==========================================
+ Coverage 71.89% 73.36% +1.46%
==========================================
Files 77 77
Lines 13715 13878 +163
==========================================
+ Hits 9861 10182 +321
+ Misses 3854 3696 -158 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces minor improvements to the models for heat exchangers:
-The fuel can now have a non-zero enthalpy of vaporization. If there is no heat exchanger, this is accounted for in the burner, where the fuel is vaporized. With heat exchangers, the fuel gets vaporized before entering the burner.
-The heat exchanger mass and diameter are now stored, so that constraints can be applied to them.
-The heat exchanger additional mass fraction is now an input.
-The additional shaft length required due to the heat exchangers is now modeled.
-A relaxation factor is added to the heat exchanger properties in wsize, so that it does not change as much across iterations and potentially speeds up convergence.