-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reviving H2, better cabin layout and double decker models #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bug fix + better way to find min R removed print statement
fixed h2 plotting fixed radius resizing code fixed all tests after updating fuse code changed name lcylcabin + h2 tests
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #78 +/- ##
==========================================
+ Coverage 71.88% 73.32% +1.43%
==========================================
Files 77 77
Lines 13684 13846 +162
==========================================
+ Hits 9837 10152 +315
+ Misses 3847 3694 -153 ☔ View full report in Codecov by Sentry. |
ngomezve
force-pushed
the
dev_fuse_refact
branch
from
August 27, 2024 09:01
a32b510
to
57a4936
Compare
changed cryo example file removed print statement
ngomezve
force-pushed
the
dev_fuse_refact
branch
from
August 29, 2024 08:35
57a4936
to
018c044
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a revised version of PR #67, with changes made after the fuselage data revamping. In addition to the changes in 67, it fixes the conflicts with the H2 models.
From PR #67, it also introduces better design options if the fuselage layout has to be redesigned; for example, following a change in fuselage radius. The following changes are included:
cabin
field to thefuselage
struct, where the cabin-related parameters are stored. The relevant parameters are eliminated from parg.