Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing issue with linear algebra threads #65

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

ngomezve
Copy link
Contributor

@ngomezve ngomezve commented Jul 1, 2024

This PR is a simplified version of PR #58. It just adds the final fix that we found for the LU decomposition issue in blax(), which would take 3 orders of magnitude longer on a server with 1 CPU than it should.

The issue is resolved by setting the number of threads in the OpenBLAS linear algebra library to 1, to avoid any parallelization. Note that this may become an issue in the future if explicit parallelization is attempted in TASOPT. For now, it should provide significant speed improvements if run on a server.

@codecov-commenter
Copy link

codecov-commenter commented Jul 1, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.27%. Comparing base (78ba4b2) to head (a1371a0).
Report is 22 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #65      +/-   ##
==========================================
+ Coverage   76.41%   78.27%   +1.85%     
==========================================
  Files          69       71       +2     
  Lines       13169    13420     +251     
==========================================
+ Hits        10063    10504     +441     
+ Misses       3106     2916     -190     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@askprash askprash merged commit 3efffcc into MIT-LAE:main Jul 2, 2024
3 checks passed
@ngomezve ngomezve deleted the dev_blas branch July 2, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants