Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring the fuselage sizing #57

Merged
merged 115 commits into from
Aug 6, 2024
Merged

Conversation

askprash
Copy link
Member

@askprash askprash commented Jun 4, 2024

@aditeyashukla starting a draft PR here so that others can also see what we've been up to and add any suggestions.

This PR refactors the fuselage sizing code to be more modular, easy to read and more efficient.

Some of the updates/features:

  • Introduce the Fuselage, FuselageLayout, and a couple other types that make it easier to define and size the fuselage
  • StructuralMembers are a generic type that can be used to represent various structural components - e.g., in the fuselage this may be the skin, the floor, etc.
  • We introduce loads.jl that has lets us define Weights and more semantically calculate the moments of weights. Also have some basic coordinate system introduced (e.g., now we can associate loads/ weights with a Frame which defaults to a privileged WORLD frame. This can allow us to translate between frames more easily. We may potentially replace this with homogenous coordinates if we start to find it useful enough.

@codecov-commenter
Copy link

codecov-commenter commented Aug 1, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 58.49858% with 293 lines in your changes missing coverage. Please review.

Project coverage is 71.88%. Comparing base (78ba4b2) to head (cb36835).
Report is 34 commits behind head on main.

Files Patch % Lines
src/IO/save_model.jl 0.00% 147 Missing ⚠️
src/structures/loads.jl 54.79% 33 Missing ⚠️
src/misc/fuselage_geometry.jl 66.66% 32 Missing ⚠️
src/structures/update_fuse.jl 44.11% 19 Missing ⚠️
src/misc/materials.jl 31.57% 13 Missing ⚠️
src/IO/quicksave_load.jl 0.00% 10 Missing ⚠️
src/sizing/wsize.jl 78.04% 9 Missing ⚠️
src/IO/read_input.jl 87.69% 8 Missing ⚠️
src/balance/balance.jl 75.86% 7 Missing ⚠️
src/misc/layout.jl 84.61% 4 Missing ⚠️
... and 6 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #57      +/-   ##
==========================================
- Coverage   76.41%   71.88%   -4.53%     
==========================================
  Files          69       77       +8     
  Lines       13169    13684     +515     
==========================================
- Hits        10063     9837     -226     
- Misses       3106     3847     +741     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@askprash askprash force-pushed the dev_fuse_remodel branch 2 times, most recently from b893071 to 1066729 Compare August 1, 2024 18:55
@askprash askprash marked this pull request as ready for review August 5, 2024 22:25
@askprash askprash mentioned this pull request Aug 5, 2024
@askprash askprash merged commit d2d9b34 into MIT-LAE:main Aug 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tail cone sizing bug Inconsistency in insulation calculation Floor sizing bug in fusew
3 participants