Refactoring the fuselage sizing #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #57 +/- ##
==========================================
- Coverage 76.41% 71.88% -4.53%
==========================================
Files 69 77 +8
Lines 13169 13684 +515
==========================================
- Hits 10063 9837 -226
- Misses 3106 3847 +741 ☔ View full report in Codecov by Sentry. |
askprash
force-pushed
the
dev_fuse_remodel
branch
2 times, most recently
from
b893071
to
1066729
Compare
minor tidying on tests add load tests to testsuite remove duplicate imports in regression test clean up loads unit test
update material tests export some material classes for convenience
del temp file
askprash
force-pushed
the
dev_fuse_remodel
branch
from
1066729
to
1d928d6
Compare
Closed
aditeyashukla
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@aditeyashukla starting a draft PR here so that others can also see what we've been up to and add any suggestions.
This PR refactors the fuselage sizing code to be more modular, easy to read and more efficient.
Some of the updates/features:
Fuselage,FuselageLayout, and a couple other types that make it easier to define and size the fuselageStructuralMembersare a generic type that can be used to represent various structural components - e.g., in the fuselage this may be the skin, the floor, etc.loads.jlthat has lets us defineWeightsand more semantically calculate the moments of weights. Also have some basic coordinate system introduced (e.g., now we can associate loads/ weights with aFramewhich defaults to a privilegedWORLDframe. This can allow us to translate between frames more easily. We may potentially replace this with homogenous coordinates if we start to find it useful enough.