Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LTO engine calculations #31

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

Fix LTO engine calculations #31

wants to merge 10 commits into from

Conversation

askprash
Copy link
Member

@askprash askprash commented Apr 4, 2024

Engine LTO calculations were broken since the removal of NPSS. LTO.jl has now been fixed to use tfcalc instead.

Also added a version variable in TASOPT.jl and fixed a misspelled "dictionary"

src/mission/LTO.jl Outdated Show resolved Hide resolved
src/mission/LTO.jl Outdated Show resolved Hide resolved
src/mission/LTO.jl Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Apr 10, 2024

Codecov Report

Attention: Patch coverage is 98.36066% with 1 line in your changes missing coverage. Please review.

Project coverage is 76.42%. Comparing base (78ba4b2) to head (ce15dd1).
Report is 5 commits behind head on main.

Files Patch % Lines
src/mission/LTO.jl 98.36% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #31      +/-   ##
==========================================
+ Coverage   76.41%   76.42%   +0.01%     
==========================================
  Files          69       71       +2     
  Lines       13169    13435     +266     
==========================================
+ Hits        10063    10268     +205     
- Misses       3106     3167      +61     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@askprash
Copy link
Member Author

askprash commented May 3, 2024

  • Add a temperature range check that throws a warning if $T_3 \notin T_{3,limits}$

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants