Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding matching type URL to warninglists #169

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

HugeekMcGill
Copy link

All MISP Warninglists are not created equal. MISP warninglists have their characterization defined by specifying types in their “matching_attributes” --> Ex: "matching_attributes": ["domain", "hostname", "url" ],

The issue we are seeing is that a domain can also be an URL but some warninglists are missing the “matching_attributes” “URL” so the IoC will not be blocked if the type is “URL”.

Like in the below example, if the attribute (IoC) type is URL and the warninglisst doesn’t have the “matching_attributes” “URL”, the warninglists its ignored by MISP.

  • The attribute (IoC) “0f3kjf7t0dbj.wpeproxy.com” with type “domain” and “URL” is part of a warninglist with “domain” and “URL” matching_attributes. This causes the warninglist to block both attributes since it’s a protected domain and URL.
    --> "matching_attributes": ["domain", "hostname", "url"]

  • The attribute (IoC) “fs.microsoft.com” with type “domain” and “URL” is part of LIST OF KNOWN WINDOWS 10 CONNECTION ENDPOINTS with only the “domain” attributes. This causes the warninglists to block only the domain attributes since it’s a protected domain. The URL IoC will not be blocked since the warninglists haven’t detected the “URL” type.
    --> "matching_attributes": ["domain", "hostname", "domain|ip"]

Screen Shot 2020-10-30 at 1 41 23 PM

@adulau
Copy link
Member

adulau commented Nov 10, 2020

Good catch indeed. Maybe we should update first the generator script to make it persistent. I'll have a look. Thanks a lot.

@HugeekMcGill
Copy link
Author

@adulau, tell me where to check if you need help on patching the generators. I'm also investigation this week at other issues in the warning-list items.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants