Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Fix z statistic computation in computefeats2 #644

Draft
wants to merge 26 commits into
base: main
Choose a base branch
from
Draft
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
904bc01
change stats.py to compute OLS based on Pseudo-Inverse & Compute Z-st…
CesarCaballeroGaudes Nov 25, 2019
8587b79
updating pca.py to same as tedana in upstream
CesarCaballeroGaudes Nov 25, 2019
1617d2a
Changed default compute_zvalues of get_coeffs to F
Nov 25, 2019
2453c78
LIntered and changed name of function get_coeff into compute_least_sq…
Nov 27, 2019
94cc77e
Changed orientation of "beta" matrix in RSS
Nov 27, 2019
b3baa52
Renmaed compute_least_squares into get_ls_coeffs
Nov 27, 2019
487416d
Lintering and Removing part of code that is not needed anymore due to…
Nov 27, 2019
b96c3b2
Improved comments on what's going on in get_ls_coeffs
Nov 27, 2019
7061614
Corrected use of "due" in stats.py
Nov 27, 2019
4820c19
Corrected use of duecredit
Nov 27, 2019
1def734
Merge pull request #1 from smoia/patch-1
CesarCaballeroGaudes Nov 29, 2019
ba3aa26
Merge branch 'OLS_stats_modification' into OLS_stats_modification
CesarCaballeroGaudes Nov 29, 2019
2ec3b3c
Merge pull request #2 from smoia/OLS_stats_modification
CesarCaballeroGaudes Nov 29, 2019
25b5ea3
compute OLS with np.linalg.lstsq instead of np.linalg.pinv
CesarCaballeroGaudes Nov 29, 2019
8b03c2b
Removed unused parameter from computefeats2
Dec 2, 2019
88d049d
Removed unused parameter
Dec 2, 2019
adc2850
Removed unused parameter
Dec 8, 2019
f8dfc8b
Removed unused parameter
Dec 8, 2019
c679600
Added limits to betas and z_scores to avoid breaking code due to INFs.
Dec 11, 2019
2e2c63b
Merge branch 'OLS_stats_modification' of github.com:smoia/tedana into…
Dec 11, 2019
a4d2c35
Merge remote-tracking branch 'upstream/master' into OLS_stats_modific…
Dec 11, 2019
ae582b6
Modified nan_to_num to clip in order to limit arrays, removed limit o…
Dec 11, 2019
cd42798
Merge branch 'master' into OLS_stats_modification
Jan 15, 2021
d8bd355
Align indented line and keep the linter happy.
Jan 15, 2021
4c85723
Merge remote-tracking branch 'origin/main' into OLS_stats_modification
Feb 15, 2021
8cfa3ca
Rename computefeats2 as get_ls_zvalues
Feb 15, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Removed unused parameter from computefeats2
  • Loading branch information
smoia committed Dec 2, 2019
commit 8b03c2b1020d442f9f155fb3aba80b47b71c120b
2 changes: 1 addition & 1 deletion tedana/stats.py
Original file line number Diff line number Diff line change
@@ -93,7 +93,7 @@ def getfbounds(n_echos):
return f05, f025, f01


def computefeats2(data, mmix, mask=None, normalize=True):
def computefeats2(data, mmix, mask=None):
smoia marked this conversation as resolved.
Show resolved Hide resolved
"""
Converts `data` to component space using `mmix`
Comment on lines 97 to 98
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"""
Converts `data` to component space using `mmix`
"""Fits mmix to data with OLS and calculates standardized beta values and z-statistics.