Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of Parallelization to analysis.bat #4693

Merged
merged 14 commits into from
Sep 14, 2024

Conversation

talagayev
Copy link
Member

@talagayev talagayev commented Aug 29, 2024

Fixes #4663

Changes made in this Pull Request:

  • parallelization of the class BAT in analysis.bat.py
  • addition of parallelization tests (including fixtures in analysis/conftest.py)
  • update of CHANGELOG

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

Developers certificate of origin


📚 Documentation preview 📚: https://mdanalysis--4693.org.readthedocs.build/en/4693/

Added clients
added bat to conftest.py
Added parallelization to bat
adjusted
Updated Changelog
@pep8speaks
Copy link

pep8speaks commented Aug 29, 2024

Hello @talagayev! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 257:80: W291 trailing whitespace
Line 258:78: W291 trailing whitespace
Line 263:1: W293 blank line contains whitespace
Line 277:1: W293 blank line contains whitespace

Line 98:1: W293 blank line contains whitespace
Line 101:3: E111 indentation is not a multiple of four
Line 101:23: W292 no newline at end of file

Line 77:80: E501 line too long (83 > 79 characters)

Comment last updated at 2024-09-09 19:35:14 UTC

Copy link

github-actions bot commented Aug 29, 2024

Linter Bot Results:

Hi @talagayev! Thanks for making this PR. We linted your code and found the following:

Some issues were found with the formatting of your code.

Code Location Outcome
main package ⚠️ Possible failure
testsuite ⚠️ Possible failure

Please have a look at the darker-main-code and darker-test-code steps here for more details: https://github.com/MDAnalysis/mdanalysis/actions/runs/10780024172/job/29894829558


Please note: The black linter is purely informational, you can safely ignore these outcomes if there are no flake8 failures!

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.87%. Comparing base (b3208b3) to head (f55c494).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4693   +/-   ##
========================================
  Coverage    93.87%   93.87%           
========================================
  Files          173      173           
  Lines        21428    21434    +6     
  Branches      3980     3981    +1     
========================================
+ Hits         20116    20122    +6     
  Misses         858      858           
  Partials       454      454           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

movement to lines
trying to fix class static error
Copy link
Member

@hmacdope hmacdope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @talagayev!

@talagayev
Copy link
Member Author

LGTM @talagayev!

Perfect :)

@hmacdope
Copy link
Member

hmacdope commented Sep 8, 2024

Just need to fix conflicts.

@talagayev
Copy link
Member Author

Just need to fix conflicts.

Done :)

Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add a versionchanged, can copy from gnm. Thanks.

@orbeckst orbeckst self-assigned this Sep 9, 2024
Addition of versionchanged
@talagayev
Copy link
Member Author

Please also add a versionchanged, can copy from gnm. Thanks.

Added the versionchanged in the BAT class, will resolve now the conflicts :)

@hmacdope
Copy link
Member

@orbeckst can you re-review here?

@orbeckst orbeckst merged commit 4fafd51 into MDAnalysis:develop Sep 14, 2024
19 of 23 checks passed
@orbeckst
Copy link
Member

Thanks @talagayev !

@talagayev
Copy link
Member Author

Thanks @talagayev !

Happy to help :)

RMeli pushed a commit to RMeli/mdanalysis that referenced this pull request Oct 3, 2024
* Fixes MDAnalysis#4663
* Changes made in this Pull Request:
    - parallelization of the class BAT in analysis.bat.py
    - addition of parallelization tests (including fixtures in analysis/conftest.py)
    - update docs for analysis class
    - update of CHANGELOG
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MDAnalysis.analysis.bat: Implement parallelization or mark as unparallelizable
4 participants