-
Notifications
You must be signed in to change notification settings - Fork 652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try to fix numpy dev0 install in nightly wheels #4383
Conversation
Linter Bot Results:Hi @IAlibay! Thanks for making this PR. We linted your code and found the following: There are currently no issues detected! 🎉 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4383 +/- ##
==========================================
Coverage 93.41% 93.41%
==========================================
Files 171 185 +14
Lines 22511 23625 +1114
Branches 4129 4129
==========================================
+ Hits 21028 22069 +1041
- Misses 963 1036 +73
Partials 520 520 ☔ View full report in Codecov by Sentry. |
Let's see how CI looks, but I believe this should be good now. Actually on second thought, maybe the old approach was better so we could know if the dev0 build isn't picked up. From the output of pip & mamba list it seems to be good. |
Supplemented by #4502 |
Fixes #
Changes made in this Pull Request:
PR Checklist
Developers certificate of origin
📚 Documentation preview 📚: https://mdanalysis--4383.org.readthedocs.build/en/4383/