Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deploy things for py312 + OpenID Connect publishing #4325

Merged
merged 5 commits into from
Oct 27, 2023

Conversation

IAlibay
Copy link
Member

@IAlibay IAlibay commented Oct 27, 2023

Towards #4326

Title says it all

Changes made in this Pull Request:

  • cibuildwheel runners are all updated
  • updates various other actions being called

Developers certificate of origin


📚 Documentation preview 📚: https://mdanalysis--4325.org.readthedocs.build/en/4325/

@github-actions
Copy link

github-actions bot commented Oct 27, 2023

Linter Bot Results:

Hi @IAlibay! Thanks for making this PR. We linted your code and found the following:

There are currently no issues detected! 🎉

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (03a9550) 93.37% compared to head (cd9a997) 93.37%.

Additional details and impacted files
@@            Coverage Diff             @@
##           develop    #4325     +/-   ##
==========================================
  Coverage    93.37%   93.37%             
==========================================
  Files          170      184     +14     
  Lines        22295    23403   +1108     
  Branches      4075     4075             
==========================================
+ Hits         20818    21853   +1035     
- Misses         962     1035     +73     
  Partials       515      515             

see 14 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IAlibay IAlibay changed the title Update deploy things for py312 Update deploy things for py312 + OpenID Connect publishing Oct 27, 2023
@IAlibay
Copy link
Member Author

IAlibay commented Oct 27, 2023

OpenID Connect trusted publisher for test and normal PyPi have now been set for MDAnalysis and MDAnalysisTests

@IAlibay
Copy link
Member Author

IAlibay commented Oct 27, 2023

For the sake of security, all old API tokens have also been deleted.

Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope it works! Thanks for the update.

(Small question about including "develop" but I assume that this fine.)

.github/workflows/deploy.yaml Outdated Show resolved Hide resolved
with:
user: __token__
password: ${{ secrets.PYPI_API_TOKEN_SRC }}
uses: pypa/[email protected]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the MDA deployment so complicated that we can't use our action https://github.com/MDAnalysis/pypi-deployment ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cibuildwheels deployments don't work via pypi-deployment right now - that's a bit more complicated so I've not added that branch yet (it's a bit more messy because you usually want to parallelise at the level of runners for each flavour you build wheels for - you don't fully have to though, you can just trust the docker container to get it right).

One day I'll get that done, it's just not been a burning priority (although the amount of cython packages we're maintinaing is starting to grow).

What I can't stuff in a reusable action though is the arm builds (using Cirrus), those will need to exist everywhere we need those builds (currently just here).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanations!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra info for anyone reading this and going "but why cibuildwheels here and not everywhere else" (it's a recurring question we should document) - we use cibuildwheels to build anything that can't do a pure Python wheel (i.e. uses Cython).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a "maintainer FAQ" somewhere — wiki or NF drive?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately not, we have barbones deployment docs on the userguide but yeah there's just not been enough of my time to add docs for everything - that's what we applied for that SDG for though so fingers crossed!

@IAlibay IAlibay merged commit 707e043 into develop Oct 27, 2023
23 checks passed
@IAlibay IAlibay deleted the py312-deploy branch October 27, 2023 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants