-
Notifications
You must be signed in to change notification settings - Fork 652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Advertise mdakits #4297
Advertise mdakits #4297
Conversation
Linter Bot Results:Hi @lilyminium! Thanks for making this PR. We linted your code and found the following: There are currently no issues detected! 🎉 |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## develop #4297 +/- ##
==========================================
Coverage 93.40% 93.40%
==========================================
Files 170 184 +14
Lines 22257 23365 +1108
Branches 4071 4071
==========================================
+ Hits 20790 21825 +1035
- Misses 951 1024 +73
Partials 516 516 ☔ View full report in Codecov by Sentry. |
Whilst I'm here - not this PR but, is the first link really meant to say "Overview over MDAnalysis"? |
It's pulling the title from https://github.com/MDAnalysis/mdanalysis/blob/develop/package/doc/sphinx/source/documentation_pages/overview.rst |
I guess I should clarify my question - I assume it's historical but it doesn't read amazingly well. We don't need to tackle this in this PR, but I would be keen to know if it's just me thinking it's odd or not. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm otherwise
Fixes #4296
Changes made in this Pull Request:
Waiting on 1.3.0 to get onto conda-forge.
PR Checklist
Developers certificate of origin
📚 Documentation preview 📚: https://mdanalysis--4297.org.readthedocs.build/en/4297/