Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advertise mdakits #4297

Merged
merged 4 commits into from
Sep 22, 2023
Merged

Advertise mdakits #4297

merged 4 commits into from
Sep 22, 2023

Conversation

lilyminium
Copy link
Member

@lilyminium lilyminium commented Sep 21, 2023

Fixes #4296

Changes made in this Pull Request:

  • Updates to 1.3.0, adds sidebar links

Waiting on 1.3.0 to get onto conda-forge.

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

Developers certificate of origin


📚 Documentation preview 📚: https://mdanalysis--4297.org.readthedocs.build/en/4297/

@github-actions
Copy link

github-actions bot commented Sep 21, 2023

Linter Bot Results:

Hi @lilyminium! Thanks for making this PR. We linted your code and found the following:

There are currently no issues detected! 🎉

@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (8719475) 93.40% compared to head (9126a0f) 93.40%.
Report is 1 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##           develop    #4297     +/-   ##
==========================================
  Coverage    93.40%   93.40%             
==========================================
  Files          170      184     +14     
  Lines        22257    23365   +1108     
  Branches      4071     4071             
==========================================
+ Hits         20790    21825   +1035     
- Misses         951     1024     +73     
  Partials       516      516             

see 14 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lilyminium lilyminium closed this Sep 22, 2023
@lilyminium lilyminium reopened this Sep 22, 2023
@lilyminium
Copy link
Member Author

Screenshot 2023-09-22 at 4 55 07 pm

Docs wind up looking like this with the new header (it looked kind of weird without the "Documentation" header in orange)

@lilyminium lilyminium marked this pull request as ready for review September 22, 2023 15:55
@IAlibay
Copy link
Member

IAlibay commented Sep 22, 2023

Whilst I'm here - not this PR but, is the first link really meant to say "Overview over MDAnalysis"?

@lilyminium
Copy link
Member Author

is the first link really meant to say "Overview over MDAnalysis"?

It's pulling the title from https://github.com/MDAnalysis/mdanalysis/blob/develop/package/doc/sphinx/source/documentation_pages/overview.rst

@IAlibay
Copy link
Member

IAlibay commented Sep 22, 2023

is the first link really meant to say "Overview over MDAnalysis"?

It's pulling the title from https://github.com/MDAnalysis/mdanalysis/blob/develop/package/doc/sphinx/source/documentation_pages/overview.rst

I guess I should clarify my question - I assume it's historical but it doesn't read amazingly well. We don't need to tackle this in this PR, but I would be keen to know if it's just me thinking it's odd or not.

Copy link
Member

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm otherwise

.github/workflows/gh-ci.yaml Outdated Show resolved Hide resolved
@IAlibay IAlibay merged commit 427f1a7 into MDAnalysis:develop Sep 22, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Advertise MDAKits
2 participants