Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra pkg_resource use #4294

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Remove extra pkg_resource use #4294

merged 1 commit into from
Sep 21, 2023

Conversation

IAlibay
Copy link
Member

@IAlibay IAlibay commented Sep 20, 2023

Towards Python 3.12

Changes made in this Pull Request:

  • Remove an extra pkg_resource use that we hadn't previously noticed.

PR Checklist

  • Tests?

Developers certificate of origin


📚 Documentation preview 📚: https://mdanalysis--4294.org.readthedocs.build/en/4294/

@github-actions
Copy link

Linter Bot Results:

Hi @IAlibay! Thanks for making this PR. We linted your code and found the following:

Some issues were found with the formatting of your code.

Code Location Outcome
main package ⚠️ Possible failure
testsuite ✅ Passed

Please have a look at the darker-main-code and darker-test-code steps here for more details: https://github.com/MDAnalysis/mdanalysis/actions/runs/6245517481/job/16954309038


Please note: The black linter is purely informational, you can safely ignore these outcomes if there are no flake8 failures!

@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (10b09c9) 93.40% compared to head (0820fa0) 93.40%.

Additional details and impacted files
@@            Coverage Diff             @@
##           develop    #4294     +/-   ##
==========================================
  Coverage    93.40%   93.40%             
==========================================
  Files          170      184     +14     
  Lines        22256    23365   +1109     
  Branches      4071     4071             
==========================================
+ Hits         20789    21825   +1036     
- Misses         951     1024     +73     
  Partials       516      516             
Files Changed Coverage Δ
package/MDAnalysis/analysis/data/filenames.py 100.00% <100.00%> (ø)

... and 14 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@richardjgowers richardjgowers merged commit 8719475 into develop Sep 21, 2023
24 checks passed
@richardjgowers richardjgowers deleted the pkg_resources branch September 21, 2023 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants