Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PDBQT docs to accurately say that last letter of segid is used as chainID #4288

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

lilyminium
Copy link
Member

@lilyminium lilyminium commented Sep 12, 2023

Fixes #4287

Changes made in this Pull Request:

  • Updates last to say first

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

Developers certificate of origin


📚 Documentation preview 📚: https://mdanalysis--4288.org.readthedocs.build/en/4288/

@github-actions
Copy link

Linter Bot Results:

Hi @lilyminium! Thanks for making this PR. We linted your code and found the following:

There are currently no issues detected! 🎉

@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (16647cb) 93.40% compared to head (10768e4) 93.40%.

Additional details and impacted files
@@            Coverage Diff             @@
##           develop    #4288     +/-   ##
==========================================
  Coverage    93.40%   93.40%             
==========================================
  Files          170      184     +14     
  Lines        22250    23358   +1108     
  Branches      4071     4071             
==========================================
+ Hits         20783    21818   +1035     
- Misses         951     1024     +73     
  Partials       516      516             
Files Changed Coverage Δ
package/MDAnalysis/coordinates/PDBQT.py 83.50% <ø> (ø)

... and 14 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@tylerjereddy tylerjereddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straightforward fix, thanks

@tylerjereddy tylerjereddy merged commit 43a07e4 into MDAnalysis:develop Sep 15, 2023
21 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PDBQT segid actually uses last character, not first
3 participants