Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: NumPy recarray shim #4275

Merged
merged 1 commit into from
Sep 4, 2023

Conversation

tylerjereddy
Copy link
Member

@tylerjereddy tylerjereddy commented Sep 3, 2023

[skip cirrus]


📚 Documentation preview 📚: https://mdanalysis--4275.org.readthedocs.build/en/4275/

* based on numpy/numpy#24587:
  * replace the single usage of `np.recarray` I found
    in our codebase--there are references to third-party
    libraries providing us with `recarray` that I haven't
    touched
  * similar PRs have been merged to `pandas` and `scipy`

[skip cirrus]
@IAlibay
Copy link
Member

IAlibay commented Sep 3, 2023

[skip cirrus]

That's interesting, do you have some kind of trigger somewhere upstream that run cirrus depending on whether or not you have a specific tag in the PR comment?

@github-actions
Copy link

github-actions bot commented Sep 3, 2023

Linter Bot Results:

Hi @tylerjereddy! Thanks for making this PR. We linted your code and found the following:

There are currently no issues detected! 🎉

@tylerjereddy
Copy link
Member Author

tylerjereddy commented Sep 3, 2023

It should work for all GitHub projects I think: https://cirrus-ci.org/guide/writing-tasks

Just include [skip ci] or [skip cirrus] in the first line or last line of your commit message in order to skip CI execution for a commit completely.

Edit: to clarify, I just paste the commit message as my PR comment as habit, but it is the commit message that gets scanned.

Copy link
Member

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tylerjereddy !

@IAlibay
Copy link
Member

IAlibay commented Sep 3, 2023

It should work for all GitHub projects I think: https://cirrus-ci.org/guide/writing-tasks

Just include [skip ci] or [skip cirrus] in the first line or last line of your commit message in order to skip CI execution for a commit completely.

Interesting, I should look at whether there's a way to do this in reverse by through tags. I.e. add in a specific task and it'll start a Cirrus CI run.

Unfortunately this is very much in the "there is no time / energy for this" camp.

@codecov
Copy link

codecov bot commented Sep 3, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (f50a097) 93.40% compared to head (cc29e8b) 93.40%.

Additional details and impacted files
@@            Coverage Diff             @@
##           develop    #4275     +/-   ##
==========================================
  Coverage    93.40%   93.40%             
==========================================
  Files          170      184     +14     
  Lines        22250    23358   +1108     
  Branches      4071     4071             
==========================================
+ Hits         20783    21818   +1035     
- Misses         951     1024     +73     
  Partials       516      516             
Files Changed Coverage Δ
...nalysis/analysis/hydrogenbonds/wbridge_analysis.py 93.06% <100.00%> (ø)

... and 14 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IAlibay
Copy link
Member

IAlibay commented Sep 3, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@hmacdope hmacdope merged commit 8d20cdc into MDAnalysis:develop Sep 4, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants