-
Notifications
You must be signed in to change notification settings - Fork 652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: NumPy recarray shim #4275
MAINT: NumPy recarray shim #4275
Conversation
* based on numpy/numpy#24587: * replace the single usage of `np.recarray` I found in our codebase--there are references to third-party libraries providing us with `recarray` that I haven't touched * similar PRs have been merged to `pandas` and `scipy` [skip cirrus]
That's interesting, do you have some kind of trigger somewhere upstream that run cirrus depending on whether or not you have a specific tag in the PR comment? |
Linter Bot Results:Hi @tylerjereddy! Thanks for making this PR. We linted your code and found the following: There are currently no issues detected! 🎉 |
It should work for all GitHub projects I think: https://cirrus-ci.org/guide/writing-tasks
Edit: to clarify, I just paste the commit message as my PR comment as habit, but it is the commit message that gets scanned. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tylerjereddy !
Interesting, I should look at whether there's a way to do this in reverse by through tags. I.e. add in a specific task and it'll start a Cirrus CI run. Unfortunately this is very much in the "there is no time / energy for this" camp. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #4275 +/- ##
==========================================
Coverage 93.40% 93.40%
==========================================
Files 170 184 +14
Lines 22250 23358 +1108
Branches 4071 4071
==========================================
+ Hits 20783 21818 +1035
- Misses 951 1024 +73
Partials 516 516
☔ View full report in Codecov by Sentry. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
numpy/__init__.py
and main namespace - Part 5 [NEP 52] numpy/numpy#24587:np.recarray
I found in our codebase--there are references to third-party libraries providing us withrecarray
that I haven't touchedpandas
andscipy
[skip cirrus]
📚 Documentation preview 📚: https://mdanalysis--4275.org.readthedocs.build/en/4275/