-
Notifications
You must be signed in to change notification settings - Fork 652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix gh cron CI #4272
Fix gh cron CI #4272
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #4272 +/- ##
===========================================
- Coverage 93.40% 93.39% -0.01%
===========================================
Files 169 184 +15
Lines 22204 23333 +1129
Branches 4064 4065 +1
===========================================
+ Hits 20740 21793 +1053
- Misses 948 1024 +76
Partials 516 516
☔ View full report in Codecov by Sentry. |
Linter Bot Results:Hi @IAlibay! Thanks for making this PR. We linted your code and found the following: Some issues were found with the formatting of your code.
Please have a look at the Please note: The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are both necessary to fix the cron-ci? Anyways, LGTM!
Well one both led to failures if that helps - this should let us have a green badge for now.. until the next numpy change |
Trying to get Cron CI back to green.
Work done in this PR:
Developers certificate of origin
📚 Documentation preview 📚: https://mdanalysis--4272.org.readthedocs.build/en/4272/