Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gh cron CI #4272

Merged
merged 5 commits into from
Aug 31, 2023
Merged

Fix gh cron CI #4272

merged 5 commits into from
Aug 31, 2023

Conversation

IAlibay
Copy link
Member

@IAlibay IAlibay commented Aug 29, 2023

Trying to get Cron CI back to green.

Work done in this PR:

  • remove GSD pin
  • switch from removed np.float_ to np.float64
  • switch from removed np.NaN to np.nan

Developers certificate of origin


📚 Documentation preview 📚: https://mdanalysis--4272.org.readthedocs.build/en/4272/

@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01% ⚠️

Comparison is base (957430b) 93.40% compared to head (ac18bd4) 93.39%.
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4272      +/-   ##
===========================================
- Coverage    93.40%   93.39%   -0.01%     
===========================================
  Files          169      184      +15     
  Lines        22204    23333    +1129     
  Branches      4064     4065       +1     
===========================================
+ Hits         20740    21793    +1053     
- Misses         948     1024      +76     
  Partials       516      516              
Files Changed Coverage Δ
package/MDAnalysis/lib/util.py 89.65% <100.00%> (ø)

... and 18 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link

github-actions bot commented Aug 29, 2023

Linter Bot Results:

Hi @IAlibay! Thanks for making this PR. We linted your code and found the following:

Some issues were found with the formatting of your code.

Code Location Outcome
main package ✅ Passed
testsuite ⚠️ Possible failure

Please have a look at the darker-main-code and darker-test-code steps here for more details: https://github.com/MDAnalysis/mdanalysis/actions/runs/6030011856/job/16360914068


Please note: The black linter is purely informational, you can safely ignore these outcomes if there are no flake8 failures!

@IAlibay IAlibay changed the title Remove gsd pin from deployed package check Fix gh cron CI Aug 29, 2023
@IAlibay IAlibay requested a review from hmacdope August 30, 2023 21:01
Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are both necessary to fix the cron-ci? Anyways, LGTM!

@IAlibay
Copy link
Member Author

IAlibay commented Aug 31, 2023

Are both necessary to fix the cron-ci? Anyways, LGTM!

Well one both led to failures if that helps - this should let us have a green badge for now.. until the next numpy change

@IAlibay IAlibay merged commit e3354d1 into develop Aug 31, 2023
20 of 21 checks passed
@RMeli RMeli deleted the fix-cron branch December 23, 2023 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants