Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch out xdrlib to mda_xdrlib #4271

Merged
merged 8 commits into from
Aug 31, 2023
Merged

switch out xdrlib to mda_xdrlib #4271

merged 8 commits into from
Aug 31, 2023

Conversation

IAlibay
Copy link
Member

@IAlibay IAlibay commented Aug 29, 2023

Fixes #3934

Changes made in this Pull Request:

  • switch out the one xdrlib usage to mda_xdrlib
  • remove unused import

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

Developers certificate of origin


📚 Documentation preview 📚: https://mdanalysis--4271.org.readthedocs.build/en/4271/

@github-actions
Copy link

github-actions bot commented Aug 29, 2023

Linter Bot Results:

Hi @IAlibay! Thanks for making this PR. We linted your code and found the following:

There are currently no issues detected! 🎉

@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (096fee7) 93.39% compared to head (7e73e7a) 93.39%.

Additional details and impacted files
@@            Coverage Diff             @@
##           develop    #4271     +/-   ##
==========================================
  Coverage    93.39%   93.39%             
==========================================
  Files          170      184     +14     
  Lines        22225    23332   +1107     
  Branches      4065     4065             
==========================================
+ Hits         20758    21792   +1034     
- Misses         951     1024     +73     
  Partials       516      516             
Files Changed Coverage Δ
package/MDAnalysis/topology/TPRParser.py 90.16% <ø> (-0.16%) ⬇️
package/MDAnalysis/topology/tpr/utils.py 95.48% <100.00%> (ø)

... and 14 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IAlibay IAlibay requested a review from orbeckst August 30, 2023 21:01
Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for making it work!!

@orbeckst
Copy link
Member

Not sure why one azure runner timed out.

@IAlibay
Copy link
Member Author

IAlibay commented Aug 31, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@IAlibay IAlibay merged commit 594dc2b into develop Aug 31, 2023
19 of 21 checks passed
@IAlibay IAlibay deleted the mda_xdrlib branch August 31, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MAINT: xdrlib is going away in Python 3.13
2 participants