-
Notifications
You must be signed in to change notification settings - Fork 652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
switch out xdrlib to mda_xdrlib #4271
Conversation
Linter Bot Results:Hi @IAlibay! Thanks for making this PR. We linted your code and found the following: There are currently no issues detected! 🎉 |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #4271 +/- ##
==========================================
Coverage 93.39% 93.39%
==========================================
Files 170 184 +14
Lines 22225 23332 +1107
Branches 4065 4065
==========================================
+ Hits 20758 21792 +1034
- Misses 951 1024 +73
Partials 516 516
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you for making it work!!
Not sure why one azure runner timed out. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Fixes #3934
Changes made in this Pull Request:
PR Checklist
Developers certificate of origin
📚 Documentation preview 📚: https://mdanalysis--4271.org.readthedocs.build/en/4271/