Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build in a new parameter: Gas Price Margin #793

Open
bertllll opened this issue May 6, 2024 · 1 comment
Open

Build in a new parameter: Gas Price Margin #793

bertllll opened this issue May 6, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@bertllll
Copy link

bertllll commented May 6, 2024

The payment process, the way we regard it now, should contain a parameter which will affect how many percents
a recommended gas price, fetched from the blockchain service provider, should be increased by in order to achieve maintaining a high rate of passes in our transactions. This way they will have as much gas that will work even after that short delay between the PaymentAdjuster's analysis, then possibly a conversation with the Neighborhood, the run adjustment of the adjustment machinery, and the actual payment stage.

Another concern to mitigate by this parameter lies in the batch structure of our RPC request. Given the possibility of processing multiple payments at once, we don't want to open up an opportunity for any of those to fail because that would mean all transactions after this one would fail too, if nothing else, just for the reason of their suddenly invalid nonces.

This parameter will come hard-coded with #GH-711 first. This card should take care of all the standard places where a configurable parameter meets the user's interface and bring it into the DB, that means the another row in the config table. When the BlockchainAgent is being constructed this value should be read from the database.

@kauri-hero kauri-hero moved this to New in MASQ Node v2 May 19, 2024
@kauri-hero kauri-hero moved this from 🆕 New to 🔖 Ready in MASQ Node v2 Jun 2, 2024
@kauri-hero kauri-hero added the enhancement New feature or request label Jun 2, 2024
@kauri-hero
Copy link

blocked by #711

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: 🔖 Ready
Status: New
Development

No branches or pull requests

2 participants