Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Begin fetching the current recommended gas price #792

Open
bertllll opened this issue May 6, 2024 · 1 comment
Open

Begin fetching the current recommended gas price #792

bertllll opened this issue May 6, 2024 · 1 comment

Comments

@bertllll
Copy link

bertllll commented May 6, 2024

If we keep using the web3 crate even after #GH-676 has been played, or somehow otherwise if it's a different library, we'll want to call the web3 JSON RPC eth_gasPrice.
In the current library there is a method under the Eth module called like so, gas_price().

This should be called in the process of constructing the BlockchainAgent, which is a place where we are also fetching this value now but only by reading a value in the DB. Such a value is probably outdated by that time and almost never changing, though. We want a dynamical value corresponding tightly to the blockchain network's demand at the moment so that the transaction can have good chances for getting picked by the miners.

There should be another parameter, gas price margin. That one, for change, should be user-oriented, and arbitrarily settable. Card #793 talks about that implementation. This margin will be denominated in percents of the recommended price as an extra to that price.

@kauri-hero kauri-hero moved this to Awaiting Development (Prioritized) in MASQ Node v2 May 19, 2024
@github-project-automation github-project-automation bot moved this to Awaiting Development (Prioritized) in MASQNode Aug 29, 2024
@kauri-hero kauri-hero moved this from 🔖 Awaiting Development (Prioritized) to 🔖 Ready in MASQ Node v2 Sep 15, 2024
@kauri-hero
Copy link

Need to rewrite this card slightly, as the gas-price is being fetched now from chain on #744

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🔖 Ready
Status: Awaiting Development (Prioritized)
Development

No branches or pull requests

2 participants