Add Persistent Title option #28
Conversation
There was a problem hiding this comment.
Hi, thanks for contributing! I've added some review comments.
As for general stuff, the commit title could be something like "Added option to have a persistent title".
In the code, I would extend all the naming to Persistent Title, it's more clear but still not too long. You could also move all the functions and structures related to the option under the one related to the Title option so it has a better grouping.
The completion scripts and manual should also be updated (for reference see commit 77ecf23 adding --fade option)
| @@ -201,6 +203,17 @@ namespace Parser { | |||
| SetFade(true, out.rainProperties); | |||
| } | |||
| }, | |||
| Option{ | |||
| BOOL, "-p", "--persistent", | |||
There was a problem hiding this comment.
I suggest going with a model similar to --fade/--no-fade for this.
There was a problem hiding this comment.
What would be the shorthand for that, or do you expect there to be none?
There was a problem hiding this comment.
We can just go with --persistent-title/--no-persistent-title. No need to add the shorter version.
|
Hi @zbot473. There was no recent activity from you so I was wondering how you would like to proceed with the PR? |
|
I've been caught up in the college application process so I can't really dedicate much time. Sorry for the delay though. |
|
No worries. Hope everything goes well with college! |
Prevents text from being overwritten by new rain streaks