-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(network): add DNS servers configuration #83
Conversation
db43fdb
to
bf61005
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #83 +/- ##
==========================================
+ Coverage 79.71% 81.65% +1.93%
==========================================
Files 18 16 -2
Lines 991 943 -48
==========================================
- Hits 790 770 -20
+ Misses 201 173 -28 ☔ View full report in Codecov by Sentry. |
Added DNS configuration for Linux, FreeBSD and MacOS (Windows TBD). Bumped MSRV to 1.80 due to stdlib LazyLock.
bf61005
to
5bc7186
Compare
Do DNS server need to be IP address all the time ? I'm a rust lang beginner. Here's how I workaround such case:[Within src/client.rs] use rsdns;
|
I think there are some possible privacy concerns when specifying DNS servers using an FQDN. So, for now, I feel Quincy should only support specifying DNS servers by their IP address, similar to WireGuard. |
c2c9726
to
02ac000
Compare
02ac000
to
b18dc10
Compare
Added DNS configuration for Linux, FreeBSD and MacOS (Windows TBD).
Bumped MSRV to 1.80 due to
std::sync::LazyLock
.Closes #76.