Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: remove tunnel, add signal handlers #44

Merged
merged 2 commits into from
Feb 25, 2024
Merged

Conversation

M0dEx
Copy link
Owner

@M0dEx M0dEx commented Feb 25, 2024

This PR removes the tunnel "middleware", opting for a server == tunnel design, simplifying a lot of task handling. It is, unfortunately, a breaking change, since there are changes to the configuration structure.

It also adds signal handlers for clean termination.

@M0dEx M0dEx self-assigned this Feb 25, 2024
Copy link

codecov bot commented Feb 25, 2024

Codecov Report

Attention: Patch coverage is 77.45098% with 46 lines in your changes are missing coverage. Please review.

Project coverage is 71.63%. Comparing base (84f42cf) to head (5ec43f0).

Files Patch % Lines
src/server.rs 83.48% 18 Missing ⚠️
src/client.rs 80.00% 9 Missing ⚠️
src/utils/tasks.rs 0.00% 9 Missing ⚠️
src/server/connection.rs 61.90% 8 Missing ⚠️
src/utils/signal_handler.rs 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #44      +/-   ##
==========================================
+ Coverage   71.15%   71.63%   +0.48%     
==========================================
  Files          20       20              
  Lines         981      913      -68     
==========================================
- Hits          698      654      -44     
+ Misses        283      259      -24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@M0dEx M0dEx changed the title refactor: remove tunnel, add signal handlers refactor!: remove tunnel, add signal handlers Feb 25, 2024
@M0dEx M0dEx merged commit 41b7e7b into main Feb 25, 2024
6 checks passed
@M0dEx M0dEx deleted the server-refactor branch February 25, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keyboard interrupt listener for clean termination
1 participant