fix(client): handle errors in traffic tasks using tokio::select!
#23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
M0dEx
force-pushed
the
hotfix/client-error-handling
branch
from
c20db37
to
f35c1a2
Compare
M0dEx
force-pushed
the
hotfix/client-error-handling
branch
from
f35c1a2
to
6030f46
Compare
M0dEx
changed the title
tokio::select!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where errors from traffic-handling tasks (
process_inbound_traffic,process_outgoing_traffic) were not handled correctly due to how thetokio::try_join!macro works.By replacing the
tokio::try_join!macro withtokio::select!, errors now get correctly propagated to the caller.