Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client): handle errors in traffic tasks using tokio::select! #23

Merged
merged 2 commits into from
Sep 26, 2023

Conversation

M0dEx
Copy link
Owner

@M0dEx M0dEx commented Sep 26, 2023

This PR fixes an issue where errors from traffic-handling tasks (process_inbound_traffic, process_outgoing_traffic) were not handled correctly due to how the tokio::try_join! macro works.

By replacing the tokio::try_join! macro with tokio::select!, errors now get correctly propagated to the caller.

@M0dEx M0dEx self-assigned this Sep 26, 2023
@M0dEx M0dEx force-pushed the hotfix/client-error-handling branch from c20db37 to f35c1a2 Compare September 26, 2023 13:48
@M0dEx M0dEx force-pushed the hotfix/client-error-handling branch from f35c1a2 to 6030f46 Compare September 26, 2023 13:49
@M0dEx M0dEx changed the title fix(client): handle errors in traffic tasks using tokio::select! fix(client): handle errors in traffic tasks using tokio::select! Sep 26, 2023
@M0dEx M0dEx merged commit b5ad2fe into main Sep 26, 2023
4 checks passed
@M0dEx M0dEx deleted the hotfix/client-error-handling branch September 26, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant