Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(utils/interface): use vectored write #13

Closed
wants to merge 1 commit into from
Closed

Conversation

M0dEx
Copy link
Owner

@M0dEx M0dEx commented Aug 7, 2023

This PR gets rid of an unnecessary Bytes copy on MacOS using vectored write.

Currently uses unstable feature for advancing a slice of IoSlices, which is not ideal, but it is necessary.

@M0dEx M0dEx added the enhancement New feature or request label Aug 7, 2023
@M0dEx M0dEx self-assigned this Aug 7, 2023
@M0dEx
Copy link
Owner Author

M0dEx commented Aug 13, 2023

There is no notable performance benefit to using vectored writes here, as there are much more significant performance bottlenecks.

@M0dEx M0dEx closed this Aug 13, 2023
@M0dEx M0dEx deleted the #9/bytes-copy branch August 13, 2023 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant