Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add static pv link in Raddar #42

Merged
merged 4 commits into from
May 21, 2024

Conversation

jlpedrosa
Copy link
Contributor

Description
Same, enable static volume provisioning so pvc can be linked to existing pv.

Checklist

  • Unit tests updated
  • End user documentation updated

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

@M0NsTeRRR
Copy link
Owner

If you want, you can create PV links for all charts in a single PR and ask me for a review once you are ready to speed up the process :)

@M0NsTeRRR M0NsTeRRR self-requested a review May 20, 2024 23:54
@jlpedrosa
Copy link
Contributor Author

If you want, you can create PV links for all charts in a single PR and ask me for a review once you are ready to speed up the process :)

That's better for me! thanks! I was trying to make each PR self contained.

@M0NsTeRRR
Copy link
Owner

That's better for me! thanks! I was trying to make each PR self contained.

Your welcome, feel free to ping me once you are done.

@jlpedrosa
Copy link
Contributor Author

@M0NsTeRRR I'd say, let's review the two that are already open, then I will create a final one with everything pending in one go?

jlpedrosa and others added 3 commits May 21, 2024 01:13
Signed-off-by: Jose Luis Pedrosa <[email protected]>
Co-authored-by: Ludovic Ortega <[email protected]>
Signed-off-by: Jose Luis Pedrosa <[email protected]>
Co-authored-by: Ludovic Ortega <[email protected]>
Signed-off-by: Jose Luis Pedrosa <[email protected]>
Signed-off-by: Jose Luis Pedrosa <[email protected]>
@M0NsTeRRR M0NsTeRRR merged commit 531c02f into M0NsTeRRR:main May 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants