targetcachehitratio is now in [0, 1] range

LuxCoreRender · Jun 29, 2018 · e93e064 · e93e064
1 parent 2a299f4
commit e93e064
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/export/config.py b/export/config.py
@@ -282,7 +282,7 @@ def _convert_dlscache_settings(scene, definitions, config):
         "lightstrategy.entry.volumes.enable": dls_cache.entry_volumes_enable,
 
         "lightstrategy.lightthreshold": dls_cache.lightthreshold / 100,
-        "lightstrategy.targetcachehitratio": dls_cache.targetcachehitratio,  # TODO maybe divide by 100 later if Dade changes it
+        "lightstrategy.targetcachehitratio": dls_cache.targetcachehitratio / 100,
         "lightstrategy.maxdepth": dls_cache.maxdepth,
         "lightstrategy.maxsamplescount": dls_cache.maxsamplescount,
     })
diff --git a/properties/config.py b/properties/config.py
@@ -143,7 +143,7 @@ class LuxCoreConfigTile(PropertyGroup):
 class LuxCoreConfigDLSCache(PropertyGroup):
     show_advanced = BoolProperty(name="Show Advanced", default=False)
 
-    # TODO names, min/max, percentage-type, descriptions
+    # TODO min/max, descriptions
     entry_radius = FloatProperty(name="Entry Radius", default=0.15, subtype="DISTANCE")
     entry_normalangle = FloatProperty(name="Normal Angle",
                                       default=radians(10), min=0, max=radians(90), subtype="ANGLE")
@@ -154,7 +154,8 @@ class LuxCoreConfigDLSCache(PropertyGroup):
                                         description="Enable/disable placement of entries in volumes")
 
     lightthreshold = FloatProperty(name="Light Threshold", default=1, min=0, max=100, subtype="PERCENTAGE")
-    targetcachehitratio = FloatProperty(name="Target Cache Hit Ratio", default=99.5, min=0, max=100, subtype="PERCENTAGE")
+    targetcachehitratio = FloatProperty(name="Target Cache Hit Ratio",
+                                        default=99.5, min=0, max=100, subtype="PERCENTAGE")
     maxdepth = IntProperty(name="Max. Depth", default=4)
     maxsamplescount = IntProperty(name="Max. Samples", default=10000000)