Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix batching to enable randomized game params + vmapping #22

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Fix batching to enable randomized game params + vmapping #22

wants to merge 10 commits into from
+1,051 −313

Conversation

StoneT2000
Copy link
Member

No description provided.

@netlify Netlify
Copy link

netlify bot commented Oct 25, 2024 •
edited
Loading

✅ Deploy Preview for lux-eye-s3 canceled.

Name Link
🔨 Latest commit e8a814e
🔍 Latest deploy log https://app.netlify.com/sites/lux-eye-s3/deploys/671d0a95b7794e00086a7b2f

CJBoey
CJBoey reviewed Oct 26, 2024
View reviewed changes
Copy link

@CJBoey CJBoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Batching with different EnvParams works now but sensor masks no longer computed correctly, I tested the changes below and it seems to fix the issue.
image

src/luxai_s3/env.py Outdated Show resolved Hide resolved
src/luxai_s3/env.py Outdated Show resolved Hide resolved
src/luxai_s3/env.py Outdated Show resolved Hide resolved
@StoneT2000
Copy link
Member Author

thanks for the suggestions, ill take a look @CJBoey

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CJBoey CJBoey CJBoey left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@StoneT2000 @CJBoey