Nerlim #1
Merged
Nerlim #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…forming loops with words. Cleaned a few type hints.
… method to Game class to award stars and xp to the user when the level is finished.
LupaDevStudio
commented
Jan 29, 2024
|
Ah au fait, il manque un ajout important à cette MR ! Il faut que tu mettes ton nom dans les crédits du readme 😉 |
…_and_new_in_path).
…ls to check that the act and level have save data before awarding stars and xp.
LupaDevStudio
commented
Feb 13, 2024
There was a problem hiding this comment.
Super pour les modifications sur le nombre d'étoiles et de xp ! Je vais juste faire un commit pour corriger un bug lié au changement du format de la position et modifier légèrement le calcul des étoiles pour se baser sur le premier dictionnaire qui rend le chemin possible.
| USER_DATA.classic_mode[self.act_name][self.lvl_name][NB_WORDS_KEY] = nb_words_found | ||
| previous_xp_fraction: float = nb_words_previous_best / nb_words_300k | ||
| # save quest word | ||
| QUEST_WORD_KEY: str = "quest_word_done" |
There was a problem hiding this comment.
Il faudra ajouter ce fameux quest word dans le json contenant les données des levels.
…rted building ClassicGame subclass of Game class and cleaned up award_stars_xp method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add class methods to attribute stars and xp when a level is completed.