Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request closes #904.
Changes made
Error analysis
Error log:
The original code
Iterator<TileEntity> iterator = null;
will be considered as unused by javac and will be optimized to bytecode like this:Which causes Iterator is missing in LVT, mod mixins cannot capture the variable and lead to errors. After fixing this, the LVT order should be
[Ljava/util/Iterator;, I, Lnet/minecraft/tileentity/TileEntity;]
Also
int tilesThisCycle = 0;
statement causes inconsistent order in local variable table, made mixins capture the wrong value. Moving to member var resolves this.