Clean up ReadFileSHA256 patch comments

LumaTeam · Dec 3, 2023 · ee3a343 · ee3a343
1 parent 65ff189
commit ee3a343
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/arm9/source/large_patches.s b/arm9/source/large_patches.s
@@ -236,6 +236,7 @@ rebootPatchSize:
 readFileSHA256Vtab11Patch: //Result Write(this, u32 off, u8 *data, u32 size)
     push {r0-r4, lr}
 
+    @ Allocate memory for DataChainProcessor struct
     sub sp, #0x14
     push {sp}
 
@@ -254,8 +255,8 @@ readFileSHA256Vtab11Patch: //Result Write(this, u32 off, u8 *data, u32 size)
     @ DataChainProcessor::Process(&proc, this, off, 0, size);
     ldr r0, [sp]
 
-    ldr r2, [sp, #0x24]
-    str r2, [sp] @ Set size field on stack
+    ldr r1, [sp, #0x24]
+    str r1, [sp] @ size argument
 
     ldr r1, [sp, #0x18]
     ldr r2, [sp, #0x1c]

diff --git a/arm9/source/patches.c b/arm9/source/patches.c
@@ -878,13 +878,13 @@ u32 patchReadFileSHA256Vtab11(u8 *pos, u32 size, u32 process9MemAddr)
 
     if((*ncchVtable11Ptr & 0x1) == 0 || (*shaVtable11Ptr & 0x1) == 0) return 1; //Must be Thumb
 
-    //Find our function address by inspecting all bl branch targets
+    //Find needed function addresses by inspecting all bl branch targets
     u16 *ncchWriteFnc = (u16 *)(pos + ((*ncchVtable11Ptr & ~0x1) - process9MemAddr));
     if(*(u32 *)ncchWriteFnc != 0x0005b5f0) return 1; //Check if we got the right function
 
     readFileSHA256Vtab11PatchCtorPtr = readFileSHA256Vtab11PatchInitPtr = readFileSHA256Vtab11PatchProcessPtr = 0;
 
-    for(; ((*ncchWriteFnc) & 0xff00) != 0xbd00; ncchWriteFnc++) {
+    for(; ((*ncchWriteFnc) & 0xff00) != 0xbd00; ncchWriteFnc++) { //Stop whe encountering a pop {..., pc}
         if((ncchWriteFnc[0] & 0xf800) != 0xf000 || (ncchWriteFnc[1] & 0xf800) != 0xf800) continue; //Check the instruction opcode
 
         s32 callOff = ((ncchWriteFnc[0] & 0x07ff) << 11) | (ncchWriteFnc[1] & 0x07ff);