removed custom mypy #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @pfranz thanks for the contributions. I was locked out of this repo for awhile after I left Luma, but I got the keys back. I just pushed some outstanding changes that I had in my fork, and they've caused some conflicts. Would you mind having a look? |
|
After resolving the conflicts I think most changes were covered by your recent commit. The only differences I see is one minor reference to 3.7 in README.md and do we still want to add a local copy of mypy to PYTHONPATH (i.e. $REPO_PATH/../mypy) in the shell scripts since we'd be getting that from pip going forward? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed the changes from the forked version of mypy had been merged. I was able to build ocio docs with a newer version of mypy. Unfortunately, mypy dropped Python 3.7 support. So I updated the references in the README to use Python 3.9.
I didn't include newer ocio stubs in this commit. I also don't have access to the other packages to test or contribute those.