Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lbustamante/core concepts #1

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

LuisBustamanteM
Copy link
Owner

@LuisBustamanteM LuisBustamanteM commented Oct 11, 2021

1 - Core Concepts Challenge

Key Features:

  • Added styling on all components with styled-components library.
  • Added Navbar Component with the following child components:
    • LeftNav
      • BurgerMenu - Menu icon which will display a sidebar (disabled at the moment).
      • SearchBar - Text input which will filter video results (disabled at the moment).
    • RightNav
      • Toggle - Switch icon which will toggle between dark and light mode (disabled at the moment).
      • UserInfo - Avatar which will display an users profile picture and user info (disabled at the moment).
  • Added CardGrid Component which displays a list of VideoCard components with video info from a mock .json file.

@cylcrow
Copy link

cylcrow commented Oct 21, 2021

Hey, Luis, I hope you're doing great.

I just reviewed your PR and it's awesome, keep it that way.

There are a couple of errors appeared on the browser console.
What can you do to solve those errors?

  • The header is rendered correctly.
  • A list of videos obtained from a mock file is displayed in the Home View.
  • CSS styles are applied correctly using the styled-components approach.

Bonus Points

  • No warnings or errors are logged in the browser console.
  • The UI is responsive

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants