Fix parsing of inline nodes children #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Will review as soon as I'm able |
stormshield-kg
force-pushed
the
fix-parsing-inline-nodes-children
branch
2 times, most recently
from
029810d to
a6de897
Compare
Lucretiel
reviewed
Sep 7, 2023
|
Good catch! I believe it's necessary for the child terminator to include any single unconditional node terminator; I've left a comment in your change addressing this. |
stormshield-kg
force-pushed
the
fix-parsing-inline-nodes-children
branch
from
a6de897 to
815fa6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix parsing of inline nodes children.