Updated for PowerRanks 1.10.10 #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
powercasgamer
suggested changes
Oct 11, 2024
powerranks/src/main/java/me/lucko/luckperms/migration/MigrationPowerRanks.java
Outdated
Show resolved
Hide resolved
jars/PowerRanks.jar
Outdated
There was a problem hiding this comment.
Ideally you open an issue on the PowerRanks repo and ask them to (properly) publish the 1.10.10 jars.
There was a problem hiding this comment.
The plugin isn't maintained anymore (or so it says on the Spigot page) so unsure if they'll answer but I'll see
|
Sorry for the lack of activity, had a long day at school yesterday and only got the time to check now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wasn't able to load the dependency from the official docs of the plugin (its repo just redirected to a compiled jar without any pom or xml files...) nor from jitpack (build kept failing) so I gave up and just went with the jar.
Probably not the best move but I was hoping you could upload it to your repo like you did with the older versions, I just made this PR for the actual java class anyways so, here it is just in case.
Closes #4