Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the change. If there is an associated issue, please include the issue link (e.g. "Closes #xxx"). For UI changes, please also include screenshots.
When I originally implemented the pager functionality in #414, I didn't realize "pager" is the common term for this. I had seen the term before but thought "viewer" was more intuitive. I have since realized I was wrong. I've renamed the field in the config, code and documentation. Additionally, I realized
PAGER
is the common env var for this, so I added support for pulling from that, in the same way we pull fromEDITOR
.Known Risks
What issues could potentially go wrong with this change? Is it a breaking change? What have you done to mitigate any potential risks?
This is very low risk because the old field name is still supported. Nothing will change about any existing user's workflows.
QA
How did you test this?
Tested manually
Checklist
CONTRIBUTING.md
already?CHANGELOG.md
?