Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search improvements #430

Merged
merged 2 commits into from
Dec 21, 2024
Merged

Search improvements #430

merged 2 commits into from
Dec 21, 2024

Conversation

LucasPickering
Copy link
Owner

@LucasPickering LucasPickering commented Dec 21, 2024

Description

Describe the change. If there is an associated issue, please include the issue link (e.g. "Closes #xxx"). For UI changes, please also include screenshots.

Replace recipe search with a filter, meaning items that don't match aren't shown. This should hopefully make it easier to find what you're looking for in a large list.

Also, propagate events not consumed by the text box to the recipe list, so you can scroll up and down while still in the text box.

Known Risks

What issues could potentially go wrong with this change? Is it a breaking change? What have you done to mitigate any potential risks?

This may still not be the right UX, but I can always change it again later.

QA

How did you test this?

Manually, updated a unit test too

Checklist

  • Have you read CONTRIBUTING.md already?
  • Did you update CHANGELOG.md?
    • Only user-facing changes belong in the changelog. Internal changes such as refactors should only be included if they'll impact users, e.g. via performance improvement.
  • Did you remove all TODOs?
    • If there are unresolved issues, please open a follow-on issue and link to it in a comment so future work can be tracked

@LucasPickering LucasPickering enabled auto-merge (rebase) December 21, 2024 01:12
@LucasPickering LucasPickering merged commit a1dbb50 into master Dec 21, 2024
15 checks passed
@LucasPickering LucasPickering deleted the search-improvements branch December 21, 2024 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant