Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't store CLI requests in history #425

Merged
merged 1 commit into from
Dec 8, 2024
Merged

Don't store CLI requests in history #425

merged 1 commit into from
Dec 8, 2024

Conversation

LucasPickering
Copy link
Owner

Description

Describe the change. If there is an associated issue, please include the issue link (e.g. "Closes #xxx"). For UI changes, please also include screenshots.

Storing requests is probably unintuitive because you wouldn't really expect CLI requests to appear in the TUI history menu. The CLI also is going to handle more bulk and large responses because of scripting.

Known Risks

What issues could potentially go wrong with this change? Is it a breaking change? What have you done to mitigate any potential risks?

Breaking change, and potentially unintuitive. This will be part of 3.0

QA

How did you test this?

Manually, added some unit tests

Checklist

  • Have you read CONTRIBUTING.md already?
  • Did you update CHANGELOG.md?
    • Only user-facing changes belong in the changelog. Internal changes such as refactors should only be included if they'll impact users, e.g. via performance improvement.
  • Did you remove all TODOs?
    • If there are unresolved issues, please open a follow-on issue and link to it in a comment so future work can be tracked

Storing requests is probably unintuitive because you wouldn't really expect CLI requests to appear in the TUI history menu. The CLI also is going to handle more bulk and large responses because of scripting.
@LucasPickering LucasPickering enabled auto-merge (rebase) December 8, 2024 23:23
@LucasPickering LucasPickering merged commit 703fce2 into 3.0 Dec 8, 2024
15 checks passed
@LucasPickering LucasPickering deleted the cli-no-history branch December 8, 2024 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant