Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typos #410

Merged
merged 2 commits into from
Nov 2, 2024
Merged

Fix typos #410

merged 2 commits into from
Nov 2, 2024

Conversation

deining
Copy link
Contributor

@deining deining commented Oct 30, 2024

This PR fixes various typos I spotted in the project.

@deining
Copy link
Contributor Author

deining commented Oct 31, 2024

All checks are passing now 😄.

ttytm
ttytm reviewed Nov 2, 2024
View reviewed changes
Copy link

@ttytm ttytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the format linter was only triggering for two of the longer doc comments with fixed typos, I think those should be the only ones for which formatting should have been fixed. Making other formatting changes seems out of scope for the PR.

@deining
Copy link
Contributor Author

deining commented Nov 2, 2024

Since the format linter was only triggering for two of the longer doc comments with fixed typos, I think those should be the only ones for which formatting should have been fixed. Making other formatting changes seems out of scope for the PR.

You are right. Just reverted all changes from my second commit not related to typo fixing.

@deining deining requested a review from ttytm November 2, 2024 20:07
ttytm
ttytm reviewed Nov 2, 2024
View reviewed changes
Copy link

@ttytm ttytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have access rights for submitting a formal approving review, but it's looking good now. Good job 👍.

@LucasPickering LucasPickering merged commit d34ba59 into LucasPickering:master Nov 2, 2024
15 checks passed
@LucasPickering
Copy link
Owner

ty!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttytm ttytm ttytm left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deining @LucasPickering @ttytm