Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ignore_certificate_hosts and large_body_size config fields #408

Merged
merged 1 commit into from
Oct 26, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),

- Preserve key order of objects in JSON responses [#405](https://github.com/LucasPickering/slumber/issues/405)

### Fixed

- Fixed `ignore_certificate_hosts` and `large_body_size` fields not being loaded from config

## [2.2.0] - 2024-10-22

### Added
Expand Down
1 change: 1 addition & 0 deletions crates/config/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ pub struct Config {
/// Command to use for in-app editing. If provided, overrides
/// `VISUAL`/`EDITOR` environment variables
pub editor: Option<String>,
#[serde(flatten)]
pub http: HttpEngineConfig,
/// Should templates be rendered inline in the UI, or should we show the
/// raw text?
Expand Down
1 change: 1 addition & 0 deletions crates/core/src/http.rs
Original file line number Diff line number Diff line change
Expand Up @@ -293,6 +293,7 @@ impl Default for HttpEngine {
}

#[derive(Debug, Serialize, Deserialize)]
#[serde(default)]
pub struct HttpEngineConfig {
/// TLS cert errors on these hostnames are ignored. Be careful!
pub ignore_certificate_hosts: Vec<String>,
Expand Down
1 change: 1 addition & 0 deletions docs/src/api/configuration/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -36,5 +36,6 @@ SLUMBER_CONFIG_PATH=~/dotfiles/slumber.yml slumber
| `editor` | `string` | Command to use when opening files for in-app editing. [More info](./editor.md) | `VISUAL`/`EDITOR` env vars |
| `ignore_certificate_hosts` | `string[]` | Hostnames whose TLS certificate errors will be ignored. [More info](../../troubleshooting/tls.md) | `[]` |
| `input_bindings` | `mapping[Action, KeyCombination[]]` | Override default input bindings. [More info](./input_bindings.md) | `{}` |
| `large_body_size` | `number` | Size over which request/response bodies are not formatted/highlighted, for performance (bytes) | `1000000` (1 MB) |
| `preview_templates` | `boolean` | Render template values in the TUI? If false, the raw template will be shown. | `true` |
| `theme` | [`Theme`](./theme.md) | Visual customizations | `{}` |
Loading