Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance for large bodies more #407

Merged
merged 2 commits into from
Oct 27, 2024

Conversation

LucasPickering
Copy link
Owner

@LucasPickering LucasPickering commented Oct 25, 2024

Description

Describe the change. If there is an associated issue, please include the issue link (e.g. "Closes #xxx"). For UI changes, please also include screenshots.

  • Disable formatting/highlighting on bodies large than the "large" body size threshold (1MB by default, but it's configurable)
  • Run body parsing in a background task

Known Risks

What issues could potentially go wrong with this change? Is it a breaking change? What have you done to mitigate any potential risks?

  • large bodies still result in pretty poor UI performance while visible on the screen, it's just not nearly as bad as it used to be
  • Lack of prettyification/highlighting might be confusing. I didn't want to spend screen real estate on a message, so supplement with a red indicator on the response size, plus some documentation

QA

How did you test this?

manually in UI

Checklist

  • Have you read CONTRIBUTING.md already?
  • Did you update CHANGELOG.md?
    • Only user-facing changes belong in the changelog. Internal changes such as refactors should only be included if they'll impact users, e.g. via performance improvement.
  • Did you remove all TODOs?
    • If there are unresolved issues, please open a follow-on issue and link to it in a comment so future work can be tracked

@LucasPickering LucasPickering force-pushed the disable-large-parsing branch 2 times, most recently from b58359c to bfba735 Compare October 26, 2024 19:16
@LucasPickering LucasPickering enabled auto-merge (rebase) October 27, 2024 12:21
@LucasPickering LucasPickering merged commit 135fc12 into master Oct 27, 2024
15 checks passed
@LucasPickering LucasPickering deleted the disable-large-parsing branch October 27, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant