Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static shell completions #395

Merged
merged 2 commits into from
Sep 30, 2024
Merged

Static shell completions #395

merged 2 commits into from
Sep 30, 2024

Conversation

LucasPickering
Copy link
Owner

@LucasPickering LucasPickering commented Sep 30, 2024

Description

Describe the change. If there is an associated issue, please include the issue link (e.g. "Closes #xxx"). For UI changes, please also include screenshots.

First step in distributing shell completions.

Known Risks

What issues could potentially go wrong with this change? Is it a breaking change? What have you done to mitigate any potential risks?

Usage for this isn't finalized, so it's not documented yet. Dynamic completions aren't implemented yet

QA

How did you test this?

Manually

Checklist

  • Have you read CONTRIBUTING.md already?
  • Did you update CHANGELOG.md?
    • Only user-facing changes belong in the changelog. Internal changes such as refactors should only be included if they'll impact users, e.g. via performance improvement.
  • Did you remove all TODOs?
    • If there are unresolved issues, please open a follow-on issue and link to it in a comment so future work can be tracked

No need to use CollectionFile outside of the TUI
@LucasPickering LucasPickering merged commit 1a0009b into master Sep 30, 2024
15 checks passed
@LucasPickering LucasPickering deleted the completions branch September 30, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant