Dynamic select changelog + docs #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anussel5559
force-pushed
the
dynamic-select-changelog-docs
branch
from
e851316 to
a8aa100
Compare
LucasPickering
requested changes
Sep 10, 2024
CHANGELOG.md
Outdated
| @@ -9,6 +9,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/), | |||
| ### Added | |||
|
|
|||
| - Use `SLUMBER_CONFIG_PATH` to customize configuration (_not_ collection) file path [#370](https://github.com/LucasPickering/slumber/issues/370) | |||
| - Add a dynamic variant to `!select` chain type, allowing your collection to present a list of values driven from the output of another chain. | |||
There was a problem hiding this comment.
Suggested change
| - Add a dynamic variant to `!select` chain type, allowing your collection to present a list of values driven from the output of another chain. | |
| - Add a dynamic variant to `!select` chain type, allowing your collection to present a list of values driven from the output of another chain. (thanks @anussel5559) |
Gotta give yourself credit!
| source: !select | ||
| message: Select Fruit | ||
| options: | ||
| source: "{{chains.request_fruit}}" |
There was a problem hiding this comment.
Suggested change
| source: "{{chains.request_fruit}}" | |
| # Assume this respones body looks like: {"fruits": ["apple", "guava", "pear"]} | |
| source: "{{chains.request_fruit}}" |
anussel5559
force-pushed
the
dynamic-select-changelog-docs
branch
from
a8aa100 to
d13769c
Compare
LucasPickering
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the changelog and docs to detail new dynamic variant on
optionsin the select chain typeKnown Risks
None
QA
Docs render -
Checklist
CONTRIBUTING.mdalready?CHANGELOG.md?