Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix release by tweaking changelog #367

Merged
merged 1 commit into from
Sep 8, 2024
Merged

Fix release by tweaking changelog #367

merged 1 commit into from
Sep 8, 2024

Conversation

LucasPickering
Copy link
Owner

@LucasPickering LucasPickering commented Sep 8, 2024

Description

Describe the change. If there is an associated issue, please include the issue link (e.g. "Closes #xxx"). For UI changes, please also include screenshots.

That's an interesting commit message, isn't it. Apparently having the words "Basic" and "Bearer" in the changelog causes the CI to identify the release plan as containing "secrets", and therefore doesn't share it from the plan step to the execution steps. This error messages around this from Github are incredibly poor so I had to find the offending words with some binary search-type thing.

Known Risks

What issues could potentially go wrong with this change? Is it a breaking change? What have you done to mitigate any potential risks?

QA

How did you test this?

Checklist

  • Have you read CONTRIBUTING.md already?
  • Did you update CHANGELOG.md?
    • Only user-facing changes belong in the changelog. Internal changes such as refactors should only be included if they'll impact users, e.g. via performance improvement.
  • Did you remove all TODOs?
    • If there are unresolved issues, please open a follow-on issue and link to it in a comment so future work can be tracked

That's an interesting commit message, isn't it. Apparently having the words "Basic" and "Bearer" in the changelog causes the CI to identify the release plan as containing "secrets", and therefore doesn't share it from the plan step to the execution steps. This error messages around this from Github are incredibly poor so I had to find the offending words with some binary search-type thing.
@LucasPickering LucasPickering changed the title WIP fix release Fix release by tweaking changelog Sep 8, 2024
@LucasPickering LucasPickering enabled auto-merge (rebase) September 8, 2024 02:07
@LucasPickering LucasPickering merged commit 7f5dd03 into master Sep 8, 2024
15 checks passed
@LucasPickering LucasPickering deleted the fix-release branch September 8, 2024 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant