Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some issues with large request bodies #358

Merged
merged 4 commits into from
Sep 1, 2024
Merged

Conversation

LucasPickering
Copy link
Owner

@LucasPickering LucasPickering commented Sep 1, 2024

Description

Describe the change. If there is an associated issue, please include the issue link (e.g. "Closes #xxx"). For UI changes, please also include screenshots.

  • Don't log request bodies
  • Optimize TemplatePreview initialization to remove recursion. This fixes a stack overflow for large bodies
  • Don't store request bodies >1MB in the DB
  • Default to WARN log level

This is a first step toward #356

Known Risks

What issues could potentially go wrong with this change? Is it a breaking change? What have you done to mitigate any potential risks?

  • Losing request data
  • There's still perf issues with large bodies

QA

How did you test this?

Manual testing

Checklist

  • Have you read CONTRIBUTING.md already?
  • Did you update CHANGELOG.md?
    • Only user-facing changes belong in the changelog. Internal changes such as refactors should only be included if they'll impact users, e.g. via performance improvement.
  • Did you remove all TODOs?
    • If there are unresolved issues, please open a follow-on issue and link to it in a comment so future work can be tracked

@LucasPickering LucasPickering enabled auto-merge (rebase) September 1, 2024 15:42
@LucasPickering LucasPickering merged commit 7834740 into master Sep 1, 2024
9 checks passed
@LucasPickering LucasPickering deleted the large-bodies branch September 1, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant