Change DB binary format #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This requires wiping out all data in the local DB
LucasPickering
force-pushed
the
change-request-repr
branch
from
8b10f66 to
1f73544
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires wiping out all data in the local DB. While we're at it, I decided to make the following changes to the request/response schema, since they're breaking:
Request::urlfromStringtoUrlRequest::bodyfromOption<String>toOption<Bytes>Response::bodyfromOption<String>toOption<Bytes>The URL change frontloads some more validation which is nice. The body changes make it possible to store binary bodies.