De-deprecate {{env.VARIABLE}} source

LucasPickering · Sep 18, 2024 · 1d16067 · 1d16067
1 parent 8d74182
commit 1d16067
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 6 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -26,6 +26,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
   - Database file remains in [data dir](https://docs.rs/dirs/latest/dirs/fn.data_dir.html) on all platforms
 - Create config file on startup if it doesn't exist
 - If config file fails to load during TUI startup, display an error and fall back to the default, rather than crashing
+- De-deprecate `{{env.VARIABLE}}` template sources
+  - They'll remain as a simpler alternative to `!env` chains
 
 ### Fixed
 

diff --git a/crates/core/src/template.rs b/crates/core/src/template.rs
@@ -208,7 +208,6 @@ pub enum TemplateKey {
     #[display("{CHAIN_PREFIX}{_0}")]
     Chain(ChainId),
     /// A value pulled from the process environment
-    /// DEPRECATED: To be removed in 2.0, replaced by !env chain source
     #[display("{ENV_PREFIX}{_0}")]
     Environment(Identifier),
 }

diff --git a/docs/src/api/request_collection/template.md b/docs/src/api/request_collection/template.md
@@ -10,11 +10,11 @@ For more detail on usage and examples, see the [user guide page on templates](..
 
 There are several ways of sourcing templating values:
 
-| Source                        | Syntax                | Description                                                                                                              | Default          |
-| ----------------------------- | --------------------- | ------------------------------------------------------------------------------------------------------------------------ | ---------------- |
-| [Profile](./profile.md) Field | `{{field_name}}`      | Static value from a profile                                                                                              | Error if unknown |
-| Environment Variable          | `{{env.VARIABLE}}`    | Environment variable from parent shell/process. **Deprecated in favor of the [`!env` chain source](./chain_source.md).** | `""`             |
-| [Chain](./chain.md)           | `{{chains.chain_id}}` | Complex chained value                                                                                                    | Error if unknown |
+| Source                        | Syntax                | Description                                    | Default          |
+| ----------------------------- | --------------------- | ---------------------------------------------- | ---------------- |
+| [Profile](./profile.md) Field | `{{field_name}}`      | Static value from a profile                    | Error if unknown |
+| Environment Variable          | `{{env.VARIABLE}}`    | Environment variable from parent shell/process | `""`             |
+| [Chain](./chain.md)           | `{{chains.chain_id}}` | Complex chained value                          | Error if unknown |
 
 ## Escape Sequences